Closed Schaeff closed 4 years ago
I think that rust-crypto
is only used for SHA256, so may be it's worth to replace it all together with something more lightweight like this? Otherwise I'd switch to rust-crypto-wasm
for now, but it still takes all the libc together with it.
I think that
rust-crypto
is only used for SHA256, so may be it's worth to replace it all together with something more lightweight like this? Otherwise I'd switch torust-crypto-wasm
for now, but it still takes all the libc together with it.
I made a pull request regarding this issue https://github.com/matter-labs/sapling-crypto/pull/12 @shamatar
Thank you @dark64 ! @Schaeff would you try to check PR #12 against you WASM target?
Hey @shamatar yes everything works fine for us with this change!
Version 0.1.1 should be now on crates.io. If it's good then please close this issue
Very good thanks!
rust-crypto
doesn't compile to wasm due to the outdatedrustc-serialize
dependency.There are fixes at different levels:
rustc-serialize
levelrust-crypto
levelOur quick fix is here but we want to avoid forking this repo.
What approach would you prefer?