matter-labs-archive / sapling-crypto

Zcash "Sapling" cryptography gadgets along with additions. Uses our Ethereum compatible bellman under the hood
Other
15 stars 9 forks source link

Reduce Poseidon hash rounds, following 2019/458. #14

Open alex-ozdemir opened 4 years ago

alex-ozdemir commented 4 years ago

This commit reduces the number of rounds in the Poseidon hash function in two ways:

Note that before this commit, the Poseidon implementation was not vulnerable, to the best of our knowledge. While the implementation appears to have made two mistakes, it made these mistakes in a way that improved, not reduced, the security.

alex-ozdemir commented 4 years ago

To be clear: if you guys want to keep the increased number of rounds for security reasons, that is more than reasonable. I'm only submitting the PR because the extra rounds seem to have been implemented by mistake.