Open alex-ozdemir opened 4 years ago
To be clear: if you guys want to keep the increased number of rounds for security reasons, that is more than reasonable. I'm only submitting the PR because the extra rounds seem to have been implemented by mistake.
This commit reduces the number of rounds in the Poseidon hash function in two ways:
R_F
parameter as the total number of full rounds.R_F
parameter as the number of full rounds on each side. That is actually theR_f
parameter.Note that before this commit, the Poseidon implementation was not vulnerable, to the best of our knowledge. While the implementation appears to have made two mistakes, it made these mistakes in a way that improved, not reduced, the security.