matter-labs / block-explorer

zkSync Era Block Explorer
Apache License 2.0
125 stars 110 forks source link

fix: different no transaction messages for non-existing and empty batches/blocks #107

Closed vasyl-ivanchuk closed 11 months ago

vasyl-ivanchuk commented 11 months ago

What ❔

Different no transaction messages for non-existing and empty batches/blocks: Empty batch:

image

Non-existing batch:

image

Why ❔

For better UX we want to show different no transaction messages in different cases: This Batch doesn’t have any transactions - for empty batch, This Batch has not been created or sealed yet - for non-existing batch, same for blocks.

Checklist

github-actions[bot] commented 11 months ago

API E2E Test Results

206 tests   206 :heavy_check_mark:  28s :stopwatch:   14 suites      0 :zzz:     1 files        0 :x:

Results for commit 16444f54.

github-actions[bot] commented 11 months ago

Visit the preview URL for this PR (updated for commit 16444f5):

(expires Mon, 11 Dec 2023 05:52:50 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e508f9012944951194447cb8885950b451a24403

github-actions[bot] commented 11 months ago

Unit Test Results

       3 files     246 suites   8m 26s :stopwatch: 1 938 tests 1 937 :heavy_check_mark: 1 :zzz: 0 :x: 1 964 runs  1 963 :heavy_check_mark: 1 :zzz: 0 :x:

Results for commit 16444f54.

github-actions[bot] commented 11 months ago

:tada: This PR is included in version 2.31.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: