search

matter-labs / block-explorer

zkSync Era Block Explorer
Apache License 2.0
125 stars 110 forks source link

test: covering Batches API and partially covered Transactions #156

Closed amelnytskyi closed 9 months ago

amelnytskyi commented 9 months ago

covering Batches API

What ❔

1506 [Transactions] /transactions response returns elements (wasn't covered fully) 1513 [Batches] /batches response returns elements (wasn't covered fully) 1510 [Transactions] /address/{address}/logs response returns elements (wasn't covered fully) 1656 [Transactions] Verify failed tx (new test) 1655 [Transactions] Verify deployed the own ERC20 token contract in BE (new test)

Why ❔

Why are these changes done? - expanding test coverage

Checklist

github-actions[bot] commented 9 months ago

API E2E Test Results

206 tests   206 :white_check_mark:  28s :stopwatch:  14 suites    0 :zzz:   1 files      0 :x:

Results for commit c9537b9e.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 9 months ago

Visit the preview URL for this PR (updated for commit c9537b9):

(expires Tue, 06 Feb 2024 13:56:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e508f9012944951194447cb8885950b451a24403

github-actions[bot] commented 9 months ago

Unit Test Results

    3 files    247 suites   8m 35s :stopwatch: 1 970 tests 1 969 :white_check_mark: 1 :zzz: 0 :x: 1 996 runs  1 995 :white_check_mark: 1 :zzz: 0 :x:

Results for commit c9537b9e.

:recycle: This comment has been updated with latest results.

amelnytskyi commented 9 months ago

@pcheremu could you please review the PR? Thanks in advance

pcheremu commented 9 months ago

@amelnytskyi please also fix failed ui test: ✘ 5 [chromium] › nft.spec.ts:32:5 › Check the L1 NFT contract address

amelnytskyi commented 9 months ago

@amelnytskyi please also fix failed ui test: ✘ 5 [chromium] › nft.spec.ts:32:5 › Check the L1 NFT contract address

@pcheremu fix for "Check the L1 NFT contract address" added - you can review again