matter-labs / block-explorer

zkSync Era Block Explorer

Apache License 2.0

123 stars 104 forks source link

test: new formatting and screenshots addition #231

Closed olehbairak closed 5 months ago

olehbairak commented 5 months ago

What ❔

Why ❔

Checklist

[ ] PR title corresponds to the body of PR (we generate changelog entries from PRs).
[ ] Tests for the changes have been added / updated.
[ ] Documentation comments have been added / updated.

pcheremu commented 5 months ago

@olehbairak Please create a task to clean extra ZKF tags and check if test case contains only one (manual or automated tag). feel free to merge this PR to the initial and create another one based on linear task or make this fix in the same PR. @amelnytskyi fyi

olehbairak commented 5 months ago

Later lets decide, do we want to have Automated and partly manual together. F.e. test id212 tags: ['Artifacts', 'Automated', 'Full test', 'Single-file', 'Smart Contract Verification page', 'Smoke test', 'Solidity', 'Active Partly Manual']

Yes, totally agree. We need to define whether these is the same, cause in fact they are partly automated, or to have only one identifier.

amelnytskyi commented 5 months ago

Later lets decide, do we want to have Automated and partly manual together. F.e. test id212 tags: ['Artifacts', 'Automated', 'Full test', 'Single-file', 'Smart Contract Verification page', 'Smoke test', 'Solidity', 'Active Partly Manual']

Let's have only 'Active Partly Manual' for such cases - WDYT?

pcheremu commented 5 months ago

Yep, Lets keep only one tag the will describe the status. And be careful with signing that we unexpectedly see here.