search

matter-labs / block-explorer

zkSync Era Block Explorer
Apache License 2.0
125 stars 110 forks source link

feat: use new tokens api #91

Closed Romsters closed 11 months ago

Romsters commented 11 months ago

What ❔

github-actions[bot] commented 11 months ago

API E2E Test Results

206 tests   206 :heavy_check_mark:  28s :stopwatch:   14 suites      0 :zzz:     1 files        0 :x:

Results for commit cfd82dce.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 11 months ago

Visit the preview URL for this PR (updated for commit cfd82dc):

(expires Mon, 27 Nov 2023 14:35:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e508f9012944951194447cb8885950b451a24403

github-actions[bot] commented 11 months ago

Unit Test Results

       3 files     244 suites   8m 37s :stopwatch: 1 920 tests 1 919 :heavy_check_mark: 1 :zzz: 0 :x: 1 946 runs  1 945 :heavy_check_mark: 1 :zzz: 0 :x:

Results for commit cfd82dce.

:recycle: This comment has been updated with latest results.

JackHamer09 commented 11 months ago

I see that there are only 42 tokens in the list on mainnet. It seems because of the liquidity filter. Is this Era liquidity for these tokens? Cause the list looks really weird tbh. Also what about the testnets? Do we have any token data for testnets?

Romsters commented 11 months ago

I see that there are only 42 tokens in the list on mainnet. It seems because of the liquidity filter. Is this Era liquidity for these tokens? Cause the list looks really weird tbh. Also what about the testnets? Do we have any token data for testnets?

There are more tokens displayed now in fact, and yes, some of the tokens are not displayed because of the liquidity filter. This is not Era liquidity, this is global liquidity. We don't have tokens data for testnet, I think this is fine, etherscan also doesn't have testnet tokens data as there is no liquidity on testnet.

I think there is no need to display tokens with < 1m of liquidity, but this can be adjusted actually. We can display all the tokens with l1 address if we want, but then all the tokens anyone bridged (including spam) will be displayed.

github-actions[bot] commented 11 months ago

:tada: This PR is included in version 2.29.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: