matter-labs / era-test-node

In-memory node that can be used for integration testing and debugging.

https://matter-labs.github.io/era-test-node

Apache License 2.0

313 stars 76 forks source link

feat: populate block fields #360

Closed itegulov closed 1 month ago

itegulov commented 1 month ago

What :computer:

Makes sure that all block fields are set to reasonable values

Why :hand:

See #358 for motivation

itegulov commented 1 month ago

@popzxc sorry, I should have been more clear about the scope of the PR. There are indeed many problems with how we create empty blocks and I was planning to address that in a separate PR that reworks when they are added (right now every second block is empty, see https://github.com/matter-labs/era-test-node/issues/362). I will cherry pick the relevant changes here.

popzxc commented 1 month ago

@itegulov it's up to you -- we can have multiple granular PRs (that probably will work better, actually), no need to bring everything to a single PR. I just wanted to highlight that this PR doesn't close #358 as it doesn't solve the problem that caused the issue to be created.

itegulov commented 1 month ago

I just wanted to highlight that this PR doesn't close https://github.com/matter-labs/era-test-node/issues/358 as it doesn't solve the problem that caused the issue to be created.

Ah, fair enough, I removed the wording that would close it.