matter-labs / zksync-docs

Developer documentation site for zkSync community.

https://docs.zksync.io/

Apache License 2.0

6 stars 17 forks source link

feat: initial quickcode guide for deploying contract using hardhat or foundry #10

Closed dutterbutter closed 3 months ago

dutterbutter commented 3 months ago

What :computer:

Adds initial quickstart guide framework
Adds components for organizing content
Adds reusable content in partials

Why :hand:

Includes quickstart for deploying, factories, testing, upgrading, and general paymaster flow
Components are helpful for displaying and organizing content

Evidence :camera:

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

github-actions[bot] commented 3 months ago

Visit the preview URL for this PR (updated for commit bd29f18):

https://zksync-docs-staging-5eb09--pr10-db-quickcode-guide-ad616y3l.web.app

_{(expires Mon, 22 Apr 2024 17:57:37 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: bfaafba5fa82d4f63473aaa76a21fabf1fbb3a11}

dutterbutter commented 3 months ago

@itsacoyote looks awesome! One thought, curious your opinion here, it seems to me that the spacing between tags is rather large. Do you feel the same? Reviewing that preview, it just seems like a lot of white space to me, idk.

itsacoyote commented 3 months ago

@dutterbutter I also feel like it's a little larger than I like, but it's following automatic styling for paragraph tags. The difference between this change and the previous is one is paragraph tags for each line vs an unordered list.

This was an extremely quick implementation to clean up the components and use something "cheap". I do prefer some tighter styling on the list and make it an actual list later on down the line.