docs: update atlas links + inline scripts

matter-labs / zksync-docs

Developer documentation site for zkSync community.

https://docs.zksync.io/

Apache License 2.0

4 stars 14 forks source link

docs: update atlas links + inline scripts #132

Closed alpinevm closed 4 days ago

alpinevm commented 3 weeks ago

Updated Atlas documentation links and references as per our internal upgrade of ZKsync within Atlas.

uF4No commented 2 weeks ago

Looks like paymaster-transaction.ts is not working as expected as the tx is paid in ETH instead of the ERC20 token.

alpinevm commented 2 weeks ago

Updated link to template with fixed paymaster script. The problem had to do with the EIP712 txn request being ignored by default ethers used by hardhat, so fix was to use Contract from zksync-ethers.

itsacoyote commented 1 week ago

@alpinevm would you mind updating your branch from main? We just had a recent update to our dependencies and getting those latest changes should fix the breaking CI checks.

alpinevm commented 1 week ago

@itsacoyote Done!

itsacoyote commented 4 days ago

Sorry, we have one last requirement to get this PR merged in, @alpinevm. All commits need to be signed, you can follow the general instructions on our Contribution Guidelines. I am consulting with our security team if we can adjust this requirement, but it does not allow me to merge right now without signed commits.

alpinevm commented 4 days ago

Apologies, it seems that rebasing on the Github UI "unsigned" my commits? Regardless, I've resigned all of them.

github-actions[bot] commented 4 days ago

:tada: This issue has been resolved in version 1.8.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: