matter-labs / zksync-docs

Developer documentation site for zkSync community.
https://docs.zksync.io/
Apache License 2.0
5 stars 27 forks source link

feat: adds community docs back and best practices #58

Closed dutterbutter closed 4 months ago

dutterbutter commented 4 months ago

What :computer:

Why :hand:

Evidence :camera:

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

github-actions[bot] commented 4 months ago

Visit the preview URL for this PR (updated for commit 672a601):

https://zksync-docs-staging-5eb09--pr58-db-add-support-docum-5zl5h1p4.web.app

(expires Tue, 21 May 2024 14:49:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: bfaafba5fa82d4f63473aaa76a21fabf1fbb3a11

dutterbutter commented 4 months ago

@itsacoyote github is acting weird....I made the changes requested and they are viewable in https://github.com/matter-labs/zksync-docs/pull/58/commits/93313ee398362b4ddcb62c2ada6dfa4ecdf34342 but for whatever reason its not registering those changes in files changed tab?? Do you experience the same?

itsacoyote commented 4 months ago

@itsacoyote github is acting weird....I made the changes requested and they are viewable in 93313ee but for whatever reason its not registering those changes in files changed tab?? Do you experience the same?

I see the commit changes, but yeah it's not showing them in the Changes tab 🤷🏻

itsacoyote commented 4 months ago

@itsacoyote github is acting weird....I made the changes requested and they are viewable in 93313ee but for whatever reason its not registering those changes in files changed tab?? Do you experience the same?

Ah, I see the issue now. You edited different files from the ones I commented on. You did change one <hr> to a --- but there are still a few more in the file I commented on!