matter-labs / zksync-docs

Developer documentation site for zkSync community.
https://docs.zksync.io/
Apache License 2.0
5 stars 15 forks source link

fix: adds NPM warning #95

Closed uF4No closed 1 month ago

uF4No commented 1 month ago

What :computer:

Why :hand:

Evidence :camera:

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

github-actions[bot] commented 1 month ago

Visit the preview URL for this PR (updated for commit c83ff65):

https://zksync-docs-staging-5eb09--pr95-fix-devrl-702-zgkek0rt.web.app

(expires Thu, 06 Jun 2024 11:58:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: bfaafba5fa82d4f63473aaa76a21fabf1fbb3a11

itsacoyote commented 1 month ago

Is this because we can't resolve the dependency issues for now?

uF4No commented 1 month ago

@itsacoyote it's because NPM does not resolve the dependencies as the other package managers and zksync-cli automatically runs simply npm i (without the --force). I think this issue will be resolved soon when the zksync-contracts package is updated to use the latest v4 of OZ contracts, but that's only happening after the protocol upgrade on mainnet 🫤