matter-labs / zksync-sso-clave-contracts

ZKsync SSO Contracts based on Clave
GNU General Public License v3.0
7 stars 1 forks source link

fix: disable user verification #180

Closed cpb8010 closed 2 weeks ago

cpb8010 commented 2 weeks ago

Description

We have a user who is getting this error even when it defaults to preferred, and we're discouraging it in other places. Also attempting to block Windows Hello before hasn't been successful, as Chrome thinks we should be able to support it.

Additional context

Evidence

Signing in with Windows (on edge) works when using the "use mobile authenticator" option. image

Changing the supported algorithms didn't change Windows showing PIN/FaceId, and it looks like it worked at least within the PR, so it's possible that Windows Hello can use ES256? It could also just be the test setup here.

github-actions[bot] commented 2 weeks ago

Visit the preview URL for this PR (updated for commit ccb9f7b):

https://zksync-auth-server-staging--pr180-user-verification-haa4031p.web.app

(expires Tue, 26 Nov 2024 16:36:06 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7