search

matter-labs / zksync

zkSync: trustless scaling and privacy engine for Ethereum
https://zksync.io
Apache License 2.0
4.88k stars 2.69k forks source link

Some bugs about Java development #356

Open tuntuntutu001 opened 2 years ago

tuntuntutu001 commented 2 years ago
  1. Regarding Java developers, when using it, not only need to introduce io.zksync in pom.xml, but also need to introduce net.java.dev.jna
  2. After testing, io.zksync does not support the lower version of the SpringBoot framework, so the org.springframework.boot version needs to be updated, and the 2.6.0 version is available after testing
  3. In the development document https://zksync.io/api/sdk/java/tutorial.html#checking-your-zksync-balance, the demo about Checking your zkSync balance:the second line of code: String balanceStr = state. getCommitted().getBalances().getOrDefault("ETH", "0"); It is wrong, the correct one should be String balanceStr = wallet.getState().getCommitted().getBalances().getOrDefault("ETH", "0");
  4. In the development document https://zksync.io/api/sdk/java/tutorial.html#withdrawing-funds-back-to-ethereum, the demo about Withdrawing funds back to Ethereum, the fourteenth line, .feeToken (ETH_IDENTIFIER), I did not find the parameter ETH_IDENTIFIER, did it introduce the wrong parameter in the SDK?
  5. Regarding Java development documents, there is no more description of contracts, such as creating contracts, calling methods in contracts, etc. I think contracts are very important to an ecosystem, so I hope to get more Information Regarding the contract, I also hope that zkSync can do better and better
MaximFischuk commented 2 years ago

@tuntuntutu001 Can you provide more information about 1 and 2 (Error messages)?

  1. Ok, we will fix this miss
  2. ETH_IDENTIFIER not provided by SDK at all, it just an example. We will add a little bit information in out documentation
  3. ZkSync doesn't support contracts