search

matterandvoid-space / subscriptions

A subscriptions library over a source of data (forked + extracted from re-frame)
Other
50 stars 1 forks source link

Is it possible to use this with vanilla Fulcro (not headless)? #34

Closed joshcho closed 1 year ago

joshcho commented 1 year ago

As in title. The fulcro example in the examples directory seems to be missing things (like reactive looks incomplete).

joshcho commented 1 year ago

I see that you removed any integration with Fulcro UI in https://github.com/matterandvoid-space/subscriptions/commit/637471af49267d5ecfdd5ac0cec4b15447ebb405. Will the Fulcro UI use case not be supported? If so, I think it would be nice for new users to see that somewhere.

dvingo commented 1 year ago

Hi @joshcho that was my original hope/goal, but I could not figure out how to make it work; furthermore after many years of struggling with fulcro's UI layer I now strongly disadvise its use. I have fully embraced the react hooks based approach, using fulcro only for state management.

I will update the docs to indicate that there is no support for fulcro UI components.

That all being said, if that feature provides utility to others I don't think there is much harm if someone else wants to contribute that feature, so would be open to contributions implementing that.

dvingo commented 1 year ago

https://github.com/matterandvoid-space/subscriptions/commit/1cf6c89d1c61c2514415e05c0d8449ce92f3565c