Unread count includes edits in the current channel

matterhorn-chat / matterhorn

A feature-rich Unix terminal client for the Mattermost chat system

BSD 3-Clause "New" or "Revised" License

1.02k stars 75 forks source link

Unread count includes edits in the current channel #801

Closed jtdaugherty closed 1 year ago

jtdaugherty commented 1 year ago

To reproduce:

Visit a channel.
Observe an edit of a message there by another user.

Actual behavior:

Unread count at the top of the channel list includes the edit, which is itself not so great, and also, M-l does not decrement it.

Desired behavior:

Unread count never includes edits for the current channel and/or M-l causes the unread count to get decremented.

jtdaugherty commented 1 year ago

I pushed a patch to improve the behavior described above. Although edits still count as marking a channel "unread," M-l (the ClearUnreadEvent) now properly updates the sidebar to reflect that the channel's edits have been viewed. That was the intention before, but we didn't trigger a channel list rebuild when M-l was pressed. Now we do.