search

matterhorn-chat / matterhorn

A feature-rich Unix terminal client for the Mattermost chat system
BSD 3-Clause "New" or "Revised" License
1.02k stars 75 forks source link

Allow auto-completion of all users in a comma-separated list. #827

Closed kquick closed 2 months ago

kquick commented 2 months ago

Auto-completion works for commands where one or more users can be specified and each user is a separate word (e.g. /msg @userA ... or /group-create @userA @userB ...), but it does not work for commands which take a comma-separated list of users (e.g. /groupmsg @userA,@userB ...). This is primarily because the existing auto-completion implementation expects to auto-complete the entire current word.

The observable behavior is that the user auto-completion list is presented for the first user entered to the /groupmsg command, but after the comma and subsequent '@' (user sigil), no auto-completion assistance is provided for the usernames.

This PR updates the User auto-completion to search for (the last) ,@ character sequence and only use the final portion following that last sigil as the search text for the user auto-completion. It extends the UserCompletion data structure to remember any previous portion of the line (up to and including the last ,@) and provide that on replacement so that the replacement provides the entire list and not just the last auto-completed user.

This should be fully backward compatible with existing functionality. There is a small downside in that it will "allow" auto-completion of a user list for any command (there is no filter for only auto-completing user lists for commands that accept user lists). Thus, one could type /msg @userA,@ and auto-completion assistance would be provided for selecting another user. At the present time, the LOE needed to mitigate this "downside" is probably not justified: the user can type a user-list without the auto-completion assistance anyhow, and the server will reject such a message (with normal Matterhorn display of that server rejection).

jtdaugherty commented 2 months ago

Thank you! This has bothered me for quite a while so I'm happy to see a fix for it!