mattermoran / map_launcher

Flutter plugin for launching maps
MIT License
259 stars 117 forks source link

Added Flitsmeister #139

Closed robinbonnes closed 10 months ago

robinbonnes commented 1 year ago

This PR adds support for the Flitsmeister app.

frankvollebregt commented 10 months ago

Hi! I noticed that it doesn't work on iOS devices (it opens the app without starting navigation). Also, this PR is now outdated. I made a PR to your fork to add Truckmeister and update the package. Please have a look: https://github.com/robinbonnes/map_launcher/pull/1

We do need to figure out how to use the URL scheme on iOS, though.

frankvollebregt commented 10 months ago

I just heard back from Flitsmeister, and they stated the following:

  1. iOS support for passing a location is not available and not currently planned
  2. Android support happens to work, but was never built into the app consciously

For now, we can set these packages as "Android only" and proceed with merging. @robinbonnes can you take a look at my PR over in your fork?

Otherwise, I'll create my own PR with your commits instead.

mattermoran commented 10 months ago

@frankvollebregt can you create a new pr with those and your changes? I'll make sure to mention both of you in the changelog

robinbonnes commented 10 months ago

Hey Frank, Thanks for also adding Truckmeister! I've just merged your PR, ofcourse you are always free to make your own PR.

mattermoran commented 10 months ago

hey @robinbonnes
that's awesome, could you then also make sure there's no merge conflicts? then I can merge this pr

robinbonnes commented 10 months ago

Hey @mattermoran,

I've just fixed those.

frankvollebregt commented 10 months ago

We should clearly tell that iOS is not supported for these two (at the time). We can open the app, but can't start navigation

mattermoran commented 10 months ago

@robinbonnes fantastic, thanks!

@frankvollebregt if it can only open the app itself on iOS I think it's pretty useless and we can just remove support for it and make it android only (just like some other maps)

Will clean up tomorrow and make a release.

mattermoran commented 8 months ago

Well it was a very long tomorrow but it is now available in v3 :)