Closed robinbonnes closed 10 months ago
Hi! I noticed that it doesn't work on iOS devices (it opens the app without starting navigation). Also, this PR is now outdated. I made a PR to your fork to add Truckmeister and update the package. Please have a look: https://github.com/robinbonnes/map_launcher/pull/1
We do need to figure out how to use the URL scheme on iOS, though.
I just heard back from Flitsmeister, and they stated the following:
For now, we can set these packages as "Android only" and proceed with merging. @robinbonnes can you take a look at my PR over in your fork?
Otherwise, I'll create my own PR with your commits instead.
@frankvollebregt can you create a new pr with those and your changes? I'll make sure to mention both of you in the changelog
Hey Frank, Thanks for also adding Truckmeister! I've just merged your PR, ofcourse you are always free to make your own PR.
hey @robinbonnes
that's awesome, could you then also make sure there's no merge conflicts?
then I can merge this pr
Hey @mattermoran,
I've just fixed those.
We should clearly tell that iOS is not supported for these two (at the time). We can open the app, but can't start navigation
@robinbonnes fantastic, thanks!
@frankvollebregt if it can only open the app itself on iOS I think it's pretty useless and we can just remove support for it and make it android only (just like some other maps)
Will clean up tomorrow and make a release.
Well it was a very long tomorrow but it is now available in v3 :)
This PR adds support for the Flitsmeister app.