search

mattermoran / map_launcher

Flutter plugin for launching maps
MIT License
259 stars 117 forks source link

chore: update waze base url #155

Closed kevinasurjadi closed 10 months ago

kevinasurjadi commented 11 months ago

Update Waze deeplink base url.

Reference: https://developers.google.com/waze/deeplinks#how

mattermoran commented 11 months ago

Hey. Thanks for contributing :) Is there any difference between using this and url scheme? Seems like website mentions that url scheme can still be used if we sure app is installed. And that we are sure because there's a check and web version wouldn't open is map is not installed.

mattermoran commented 11 months ago

I do plan however to add support for universal links as such for web and desktop as well some time so this would be useful later :)

kevinasurjadi commented 11 months ago

Absolutely true, I believe that universal link is a lot safer. Universal link makes us don't have to worry whether the app is installed or not. I know that this feature is not needed right now, because the method channel makes sure that the app is installed, so feel free to close this PR or if anything I can help for later. It's cool that you have a plan for supporting the universal link, I am looking forward to that. Thanks a lot.

mattermoran commented 11 months ago

There are couple of reasons I haven't made full switch to universal links.

But regardless there are ways to improve this plugin by introducing extra features enabled with universal links. Like web/desktop support as I've mentioned before. Launching web versions on mobile or opening stores to install maps, etc.

If you would like to contribute good thing to start finding universal links for maps and available parameters etc as that the part that actually takes lots of time :)

Thanks for taking interest. Appreciate any input :)

mattermoran commented 10 months ago

I'm closing this as we are not yet adding support for universal links.