mattermoran / map_launcher

Flutter plugin for launching maps
MIT License
259 stars 117 forks source link

Update build.gradle #157

Closed m-derakhshi closed 10 months ago

m-derakhshi commented 11 months ago

Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl. Namespace not specified. Please specify a namespace in the module's build.gradle file like so:

 android {
     namespace 'com.example.namespace'
 }

 If the package attribute is specified in the source AndroidManifest.xml, it can be migrated automatically to the namespace value in the build.gradle file using the AGP Upgrade Assistant; please refer to https://developer.android.com/studio/build/agp-upgrade-assistant for more information.

mattermoran commented 10 months ago

@m-derakhshi thanks for contribution!

tspoke commented 10 months ago

@mattermoran When do you plan to publish a new version on pubdev with this fix ? Thanks !

mattermoran commented 10 months ago

hey @tspoke I need to fix couple of small thingies but for now you should be able to install from git directly like

map_launcher:
    git:
      url: https://github.com/mattermoran/map_launcher.git
tspoke commented 10 months ago

Yes I already did this but I point to another commit because you removed the fix of this issue (https://github.com/mattermoran/map_launcher/commit/92074b1b22bc2ebad8759699fe918840e9546d3c#diff-197b190e4a3512994d2cebed8aff5479ff88e136b8cc7a4b148ec9c3945bd65aL29)

The namespace seems mandatory in latest android/gradle versions.

mattermoran commented 10 months ago

Ah you're right. Must've been the merge conflict. I brought it back on master.

mattermoran commented 8 months ago

This is now available in v3