feat: add support for tomtom go fleet & Sygic Truck

mattermoran / map_launcher

Flutter plugin for launching maps

MIT License

259 stars 117 forks source link

feat: add support for tomtom go fleet & Sygic Truck #158

Closed amrahmed242 closed 10 months ago

amrahmed242 commented 11 months ago

What the PR Includes

[x] Contributes to https://github.com/mattermoran/map_launcher/issues/111
[x] Add support for the TomTom Go Fleet on Android (released only for android)
[x] Add support for Sygic navigation app on Android and iOS.

Limitations

The SVG image is a converted PNG icon, and has a relatively low quality. No titles or other parameters are supported for Sygic.

note: sygic document mention that we can pass destination title but did't work.

Tesing

The marker and directions command were both verified to work on the following devices.

Google pixel 5
iphone x

amrahmed242 commented 11 months ago

@mattermoran Couldn’t assign you for review so i tagged you in this comment, thanks.

mattermoran commented 10 months ago

@amrahmed242 Thanks for contribution! This will be available in the next release.

frankvollebregt commented 10 months ago

It seems like these two apps weren't added to the README file yet in the master branch, so perhaps it'd be good to do that in additon to the changes I proposed above @mattermoran

Edit: I won't have time today I think, so feel free to do it yourself. Below are the tasks I've identified ->

Leaving the following tasks:

Update TT Go Fleet icon with background
Update the Sygic Truck icon to the correct icon
(maybe) Add Sygic non-truck
Add TT GO Fleet and Sygic to the README
Completely remove Flitsmeister/Truckmeister support on iOS

mattermoran commented 8 months ago

Released now in v3 :)

Sygic non truck will have to come later otherwise it would've kept dragging