search

mattermoran / map_launcher

Flutter plugin for launching maps
MIT License
259 stars 117 forks source link

`showMarker` and `showDirections` Futures don't complete on success on iOS #163

Closed vincent-hoodoo closed 8 months ago

vincent-hoodoo commented 8 months ago

Hello and thank you for the great and useful plugin.

I noticed that the Futures returned by MapLauncher.showMarker and MapLauncher.showDirections never complete on success on iOS (they do on Android).

It's probably just a matter of adding a call to result on https://github.com/mattermoran/map_launcher/blob/master/ios/Classes/SwiftMapLauncherPlugin.swift#L194 and on https://github.com/mattermoran/map_launcher/blob/master/ios/Classes/SwiftMapLauncherPlugin.swift#L230.

It's problematic in our case, since we wait for these Futures to complete to perform other logic.

mattermoran commented 8 months ago

Hey @vincent-hoodoo You're right, it should've definitely called the result.

Will fix up today :)

mattermoran commented 8 months ago

It's now fixed in v3 :)