mattermoran / map_launcher

Flutter plugin for launching maps
MIT License
259 stars 117 forks source link

Feature/mapy cz #171

Closed TheHumr closed 4 months ago

12people commented 4 months ago

It's not working on Android because <package android:name="cz.seznam.mapy" /> is missing from AndroidManifest.xml.

mattermoran commented 4 months ago

I don't know if it even works with that thing added in manifest. I checked the docs and it says url coords should be in the q param but here it's in the id

mattermoran commented 4 months ago

@TheHumr could you provide a video of it working on android and ios? also the docs say it does support the google-maps-like urls for direction which is not implemented

12people commented 4 months ago

I don't know if it even works with that thing added in manifest. I checked the docs and it says url coords should be in the q param but here it's in the id

It worked for me — at least, the directions link I tried worked. (Though only linking to the place and not to directions, as the API says that there's no straightforward way to build direction links.)

That said, if the docs recommend another type of linking, the code should probably be adjusted for that.

mattermoran commented 4 months ago

The docs say it supports google urls for marker and navigation I wonder if we can just use the existing google format and just trigger mapycz intent

image
mattermoran commented 4 months ago

I'm going to give it a go

mattermoran commented 4 months ago

Well nevermind, seems like current approach is probably best. Their docs suck, even the examples they themself provide don't work

No Activity found to handle Intent { act=android.intent.action.VIEW dat=http://maps.google.com/... flg=0x10000000 pkg=cz.seznam.mapy }, null, android.content.ActivityNotFoundException: No Activity found to handle Intent { act=android.intent.action.VIEW dat=http://maps.google.com/... flg=0x10000000 pkg=cz.seznam.mapy }

I tested on both android and ios and it seems to be working.

I'll get this merged

mattermoran commented 4 months ago

Published 3.2.0 with those changes.

Thanks @TheHumr