search

mattermoran / map_launcher

Flutter plugin for launching maps
MIT License
265 stars 125 forks source link

feat: adding citymapper #22

Closed Kiruel closed 4 years ago

Kiruel commented 4 years ago

Adding citymapper application to the launcher.

mattermoran commented 4 years ago

Hey @Kiruel It's looking good so far. I'll do a quick test and merge

Kiruel commented 4 years ago

@mattermoran Thanks for your quick review :)

mattermoran commented 4 years ago

@Kiruel no problem at all! Though it looks like citymapper is not supported in my current location so I cannot see what launching it looks like. You think you could make a short video or a gif of how it shows up on your phone when opening with this plugin?

Kiruel commented 4 years ago

@mattermoran You should use simulator of Android with the play store in it. And you can simulate the GPS to Paris for example and see what's going on. But yeah I can make a quick video to show you the result. (tested on iPhone XR, and OnePlus 5T and simulator Android).

Kiruel commented 4 years ago

Screen Recording 2020-06-02 at 03 04 05

mattermoran commented 4 years ago

It's usually problematic to make simulator work with the proxy so I didn't even try haha. Thanks for the vid. Looks good to me

mattermoran commented 4 years ago

Hey @Kiruel Version 0.5.0 with your changes should now be available on pub

Kiruel commented 4 years ago

Thanks 🙏 I just update my pubspec!