Bug: shared board link is generated without plugin prefix after refresh on desktop app

mattermost-community / focalboard

Focalboard is an open source, self-hosted alternative to Trello, Notion, and Asana.

https://www.focalboard.com

Other

21.63k stars 1.93k forks source link

Bug: shared board link is generated without plugin prefix after refresh on desktop app #1485

Closed mgdelacroix closed 2 years ago

mgdelacroix commented 3 years ago

Steps to reproduce the behavior

On the desktop app, load a board and share it
Check the shared url, it should start with /plugins/focalboard
Refresh with CTRL+R or from the top menu
Check the shared url, it will not start with /plugins/focalboard and will load either the login screen if you try to access it on an incognito window or the "team not found" screen

Expected behavior

The URL should be the same one that the one generated before the refresh

Edition and Platform

Edition: Mattermost plugin
Version: v0.9.1
Browser and OS: Desktop v5 on Linux

chenilim commented 3 years ago

Was able to repro this (Desktop v5 on macOS). Took a quick look:

The initial URL is https://community-daily.mattermost.com/boards/workspace/s5e9p7y5cirs3dxp163broufqa/fdae6de9-ff62-45a7-8770-a2ea318a3866/de122b7c-469d-4462-8f1f-f87ae15de044
- Got this from the View \ "Developer Tools for current tab", then window.location.href in the console
After refreshing (Cmd+R), the URL becomes https://community-daily.mattermost.com/boards/fdae6de9-ff62-45a7-8770-a2ea318a3866/de122b7c-469d-4462-8f1f-f87ae15de044
- Note that the /workspace/s5e9p7y5cirs3dxp163broufqa/ path segments are removed
This causes the shared board UI to not detect a workspace, and default to the Personal Server logic here.

@devinbinnie, any ideas why a Cmd+R would cause the URL to be modified? Is refresh being intercepted by webapp code? cc @sbishel, @harshilsharma63, @ogi-m.

devinbinnie commented 3 years ago

@chenilim Cmd+R on Desktop App causes the current view to be reloaded, but that's all I'm aware of. It would constitute the same thing as pressing F5 in the browser.

chenilim commented 3 years ago

Thanks @devinbinnie. Definitely strange. This does not repro on the browser. Something we should investigate on the Boards-side for v0.10.

devinbinnie commented 3 years ago

Curious, how come the URL starts with /plugins/focalboard and not /boards? That might cause some strange Desktop App behaviour.

chenilim commented 3 years ago

@devinbinnie (sorry, missed your comment earlier): The shared URLs are off /plugins/focalboard because they are meant to be accessed by unauthenticated users, and /boards/... would trigger an auth check. In general, the shared URLs are expected to be opened in a browser vs. the desktop app.