search

mattermost-community / focalboard

Focalboard is an open source, self-hosted alternative to Trello, Notion, and Asana.
https://www.focalboard.com
Other
21.63k stars 1.93k forks source link

Bug: Dark themes sometimes applied incorrectly in plugin/product #3803

Open hmhealey opened 2 years ago

hmhealey commented 2 years ago

Steps to reproduce the behavior

In both of the below cases, the backdrops/text on certain properties such as column labels, statuses, and multiselect properties appears as light-on-light making them difficult to read.

Repro steps 1

  1. In Channels, select a dark theme
  2. Switch to Boards using one of the following methods that opens Boards in a new tab:
    1. Clicking on the App Bar button in the top right and selecting a board to navigate to
    2. Pasting the URL for a board into the address bar

Repro steps 2

  1. In Channels, select a dark theme
  2. Switch to Boards using one of the following methods that opens Boards in the current tab:
    1. Clicking on the product switcher in the top left and selecting Boards
    2. Clicking on a URL for a board pasted in a message
  3. Note that those elements appear correctly coloured at this point
  4. Refresh the page

Expected behavior

The text appears readable as it does when you switch using the methods that open Boards in the current tab

Screenshots (optional)

Screen Shot 2022-09-08 at 11 22 54 AM

Edition and Platform

wuwinson commented 1 year ago

Also appearing in the Share dialog and confirmation dialog for autocomplete list:

image image1
asaadmahmood commented 1 year ago

@wuwinson I have consistent repro steps for this, we need to fix this as I have been getting complaints about this, and it's bothering people.

asaadmahmood commented 1 year ago

The issue here is that the HSL value on the labels changes to the hex value when refreshed.

asaadmahmood commented 1 year ago

I can still repro this, exact repro steps: https://www.loom.com/share/301b7127b6204553a0a81948585ed059

hmhealey commented 1 year ago

This is still reproducing on community, so I've updated the description that it happens in product mode as well

wuwinson commented 1 year ago

@jespino Do you mind looking into this to see why it's happening again? Thanks!

hmhealey commented 1 year ago

I'd definitely like this looked into. It's making it incredibly difficult to use Boards in the MM desktop app because there's no way around this behaviour like there would be in the web app. I'm pretty sure the issue is caused by a conflict between how Boards and MM apply their themes