search

mattermost-community / focalboard

Focalboard is an open source, self-hosted alternative to Trello, Notion, and Asana.
https://www.focalboard.com
Other
21.89k stars 1.97k forks source link

Code Debt: Share common code between Person and MultiPerson properties #4842

Open sbishel opened 2 years ago

sbishel commented 2 years ago

Summary

The Person Property and MultiPerson Property share most of the same code.

Especially after this PR made them work in an equivalent manner. We should implement a "base Person property" and update Person and MultiPerson to call this property with its specific needs.

How important this is to me and why

Importance: High

As a sameple, see how the various text properties (Text, Email, Phone, and Number) use BaseTextEditor.

cannalee90 commented 2 years ago

May I try this one

rish-singhal commented 2 years ago

I can work on this issue.

sbishel commented 2 years ago

@cannalee90 - Thanks assigning to you as first request.

cannalee90 commented 2 years ago

I'm having struggling with some problems but i think i could do it by next week