search

mattermost-community / focalboard

Focalboard is an open source, self-hosted alternative to Trello, Notion, and Asana.
https://www.focalboard.com
Other
21.99k stars 1.99k forks source link

Fix broken webapp unit tests #4951

Open Dripcoding opened 11 months ago

Dripcoding commented 11 months ago

Summary

Fix broken jest unit tests for the web app. Run 'npm run test' to run all tests.

Ticket Link

N/A

Fixes #4944

mattermost-build commented 11 months ago

Hello @Dripcoding,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

M-ZubairAhmed commented 11 months ago

Ticket mentions changes to be done in focalboard though not in this

Dripcoding commented 11 months ago

Ticket mentions changes to be done in focalboard though not in this

I opened an issue because I saw failing tests when I checked out the main branch.

M-ZubairAhmed commented 11 months ago

Ticket mentions changes to be done in focalboard though not in this

I opened an issue because I saw failing tests when I checked out the main branch.

Oh yeah sorry i mis saw this being opened in the monorepo

Dripcoding commented 11 months ago

@M-ZubairAhmed I figured out why the tests were failing in the pipeline. Turns out I had a different version of node running locally :]

Pushed the fixes and saw the tests passing when I re-triggered the actions in my forked repo. https://github.com/Dripcoding/focalboard/actions/runs/7235020646/job/19711988610?pr=2

mattermost-build commented 11 months ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

giuseongit commented 6 months ago

@Dripcoding please note that this entire project seems quite abandoned, I found this fork following this discussion that could be a replacement for a community-driven product