search

mattermost-community / focalboard

Focalboard is an open source, self-hosted alternative to Trello, Notion, and Asana.
https://www.focalboard.com
Other
21.99k stars 1.99k forks source link

MM-52722: Fixed error when accessing property on undefined #4957

Open srisri332 opened 11 months ago

srisri332 commented 11 months ago

Summary

The red JavaScript banner was due an error that was occurring when a property was trying to be accessed on undefined. This undefined value occurs only when empty lines are given in the comments box. Therefore, placed a check to not do this if there are no text values in the comment box.

Testing: check the following issue link to follow the steps to reproduce: https://github.com/mattermost/focalboard/issues/4831 Also, do a basic sanity test to see if the comment box functionality is working as expected.

Ticket Link

https://github.com/mattermost/focalboard/issues/4831 https://mattermost.atlassian.net/browse/MM-52722

mattermost-build commented 11 months ago

Hello @srisri332,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mattermost-build commented 11 months ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!