search

mattermost-community / mattermost-plugin-agenda

Mattermost plugin to handle meeting agendas
Apache License 2.0
34 stars 21 forks source link

Update Circle CI #14

Closed jfrerich closed 4 years ago

jfrerich commented 4 years ago

Summary

Sync to latest https://github.com/mattermost/mattermost-plugin-demo/blob/master/.circleci/config.yml

levb commented 4 years ago

@jfrerich @marianunez I am a little confused as to why the build is still failing, thought the intention of this PR would be to have the build green. Or are there separate PRs for the build fixes?

jfrerich commented 4 years ago

@levb, the PR is pointing to master which doesn't have the changes from https://github.com/mattermost/mattermost-plugin-agenda/pull/2. I can change the reference branch to https://github.com/mattermost/mattermost-plugin-agenda/tree/pluginReview. That PR will have a clean build.

I'm waiting on QA to review the PR before intake is completed. I'm sure they are super busy. Can we merge that PR first and assign a ticket to QA the master branch?