search

mattermost-community / mattermost-plugin-agenda

Mattermost plugin to handle meeting agendas
Apache License 2.0
35 stars 21 forks source link

Plugin review proposals #3

Closed jfrerich closed 4 years ago

jfrerich commented 4 years ago

Summary

This is a PR with suggested changes discovered during the Plugin Review Process. The purpose of this 2nd PR is to give both the plugin author and other developers the chance to review changes before pushing into master.

jfrerich commented 4 years ago

Hi @marianunez and @levb. This is a PR that can be used to let the authors and devs see the proposed changes I would make. Note this is currently a draft PR and I will be making for commits.

levb commented 4 years ago

1/5 for merging incrementally

marianunez commented 4 years ago

1/5 for merging incrementally

@levb Can you explain what you mean by incrementally?

levb commented 4 years ago

@marianunez Like, in merge the changes we already have here (once approved), and cut another PR if we need to make more changes.

marianunez commented 4 years ago

@levb sounds good. I discussed offline with @jfrerich and I think most of the other changes proposed I will continue on the original PR here https://github.com/mattermost/mattermost-plugin-agenda/pull/2

jfrerich commented 4 years ago

@levb, for this plugin, I have created this PR so that @marianunez can review the changes before merging. This is a little different than the google calendar plugin, where I basically took ownership and merged changes directly.

@marianunez, if these changes look good for your approval, let's go ahead and approve/merge and I'll create additional PRs for other changes.