search

mattermost-community / mattermost-plugin-agenda

Mattermost plugin to handle meeting agendas
Apache License 2.0
34 stars 21 forks source link

feat: default hashtag includes channel name #30

Closed will7200 closed 4 years ago

will7200 commented 4 years ago

Summary

Closes #10 Default hashtag to use the first 15 characters of a channel name prefixed to the date format.

Ticket Link

JIRA: https://mattermost.atlassian.net/browse/MM-22727

codecov[bot] commented 4 years ago

Codecov Report

Merging #30 into master will increase coverage by 11.81%. The diff coverage is 88.23%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #30       +/-   ##
===========================================
+ Coverage   16.46%   28.27%   +11.81%     
===========================================
  Files           6        6               
  Lines         328      343       +15     
===========================================
+ Hits           54       97       +43     
+ Misses        262      229       -33     
- Partials       12       17        +5
Impacted Files Coverage Δ
server/meeting.go 65.30% <88.23%> (+41.77%) :arrow_up:
server/utils.go 95.12% <0.00%> (+46.34%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 853bfe1...2302c21. Read the comment docs.

will7200 commented 4 years ago

@marianunez I was finally able to get around this, thank you for your patience. I added as instructed.

hanzei commented 4 years ago

@will7200 Heads up that I merged master into your branch to update it which has broken CI. Could you please take a look?

will7200 commented 4 years ago

@hanzei Fixed

hanzei commented 4 years ago

@will7200 Could you please resolve the merge conflicts?

will7200 commented 4 years ago

@hanzei done

hanzei commented 4 years ago

Thanks @will7200 :+1:

hanzei commented 4 years ago

@jfrerich Could you give this PR a final review?

hanzei commented 4 years ago

@marianunez @DHaussermann Should this PR get QA reviewed or can we merge it as it is?

marianunez commented 4 years ago

Should this PR get QA reviewed or can we merge it as it is?

If we do skip the QA review here, I would suggest a quick smoke test to the release before deploying to community.