search

mattermost-community / mattermost-plugin-agenda

Mattermost plugin to handle meeting agendas
Apache License 2.0
34 stars 21 forks source link

Add autocomplete suggestions #40

Closed iomodo closed 4 years ago

iomodo commented 4 years ago

Summary

This PR will add slash command autocomplete suggestions.

codecov-commenter commented 4 years ago

Codecov Report

Merging #40 into master will decrease coverage by 2.60%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   21.03%   18.42%   -2.61%     
==========================================
  Files           6        6              
  Lines         233      266      +33     
==========================================
  Hits           49       49              
- Misses        173      206      +33     
  Partials       11       11
Impacted Files Coverage Δ
server/command.go 0.00% <0.00%> (ø)
server/main.go 0.00% <ø> (ø)
server/plugin.go 36.84% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d280498...4ef1a03. Read the comment docs.

iomodo commented 4 years ago

@hanzei There will be no changes for older servers, new functionality will not work of course. No min_server_version bump is needed. We need a dependency bump to 5.24 though, to be able to compile the new autocomplete data.

DHaussermann commented 4 years ago

I have tested all the auto-complete functionality

@iomodo one question here... The schedule command functionality has changed instead of Mon or Monday you have to use 1 Was this part of this PR or do you know anything about it? I can't see a separate PR for it. In my opinion this is less usable. Also in it's current state it's wrong as the description says it will accept 1-5 however, you can schedule meetings on Saturday and Sunday with 6 and 7