mattermost-community / mattermost-plugin-agenda

Mattermost plugin to handle meeting agendas

Apache License 2.0

35 stars 21 forks source link

GH-32- Fix issue with agenda list numbering #44

Closed marianunez closed 4 years ago

marianunez commented 4 years ago

Summary

Fixed issue with numbering posts in agenda list by changing search posts to use new SearchPostsInTeamForUser api.

Ticket Link

GH-32

Related Pull Requests

Mattermost Server: https://github.com/mattermost/mattermost-server/pull/14807

codecov-commenter commented 4 years ago

Codecov Report

Merging #44 into master will decrease coverage by 0.13%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   18.42%   18.28%   -0.14%     
==========================================
  Files           6        6              
  Lines         266      268       +2     
==========================================
  Hits           49       49              
- Misses        206      208       +2     
  Partials       11       11

Impacted Files	Coverage Δ
server/command.go	`0.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aa1ac21...3d1db00. Read the comment docs.

hanzei commented 4 years ago

@prapti Given that you tested https://github.com/mattermost/mattermost-server/pull/14807 could you also test this PR?

marianunez commented 4 years ago

Is this something that can be fixed within this PR as well?

@prapti could we file this as a separate issue? This issue is not related with this PR and it's currently happening in master as well.

To fix this we would not only have to rely on the amount of posts but parse out the numbering on the last one (that may or may not be available given that people can manually queue items without numbers).

marianunez commented 4 years ago

Created a new ticket mattermost.atlassian.net/browse/MM-26536 for the issue mentioned, and approving this one.

Thanks @prapti! I've copied it to a GH issue https://github.com/mattermost/mattermost-plugin-agenda/issues/47 as well, I believe integrations team are tracking them there.