mattermost-community / mattermost-plugin-agenda

Mattermost plugin to handle meeting agendas

Apache License 2.0

34 stars 21 forks source link

CI go lint #48

Closed AugustasV closed 4 years ago

AugustasV commented 4 years ago

Summary

Uploaded build files for golint to work properly, but make dist command is failing for now.

Ticket Link

Fixes https://github.com/mattermost/mattermost-plugin-agenda/issues/43

hanzei commented 4 years ago

Hey @AugustasV, the build failed because this plugin depends on a code change in mattermost-server that is only in master. Sorry for the false guidance. Fixed the issue for you.

jfrerich commented 4 years ago

Thanks for the PR, @AugustasV! Do you need any assistance fixing the remaining build failures?

@hanzei, I noticed your comment above. Was your fix supposed to fix the build completely, or just get us to the state where a build passes?

hanzei commented 4 years ago

@hanzei, I noticed your comment above. Was your fix supposed to fix the build completely, or just get us to the state where a build passes?

I only fix an issue unrelated to this PR. There a still a couple of error to be fixed. See https://app.circleci.com/pipelines/github/mattermost/mattermost-plugin-agenda/55/workflows/f1c94453-bc56-4354-a505-47d43513afee/jobs/169/steps

AugustasV commented 4 years ago

@hanzei fixed those linter issues that I was able to fix.

jfrerich commented 4 years ago

Hi @AugustasV! Would you like assistance cleaning up the remaining Linting errors found by circleCI

AugustasV commented 4 years ago

Yea please. Any guidance would be usefull!

2020 m. liepos 28 d., antradienis Jason Frerich notifications@github.com rašė:

Hi @AugustasV https://github.com/AugustasV! Would you like assistance cleaning up the remaining Linting errors found by circleCI https://app.circleci.com/pipelines/github/mattermost/mattermost-plugin-agenda/63/workflows/21b4271c-be02-4df7-8c2e-760498b813fc/jobs/195

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mattermost/mattermost-plugin-agenda/pull/48#issuecomment-665160066, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYJDNQ7I22BCOB6IZ42RTDR54AGVANCNFSM4OMN4JGQ .

-- cs servas ip: srw.syte.net:27015

hanzei commented 4 years ago

@AugustasV I've fixed the remaining issues for you. Thanks for the work you put into this PR :+1:

codecov[bot] commented 4 years ago

Codecov Report

Merging #48 into master will increase coverage by 1.14%. The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   18.49%   19.63%   +1.14%     
==========================================
  Files           6        6              
  Lines         265      275      +10     
==========================================
+ Hits           49       54       +5     
- Misses        205      209       +4     
- Partials       11       12       +1

Impacted Files	Coverage Δ
server/command.go	`0.00% <ø> (ø)`
server/meeting.go	`28.57% <ø> (ø)`
server/utils.go	`66.66% <ø> (ø)`
server/plugin.go	`38.80% <57.14%> (+1.96%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eccb780...d1881ac. Read the comment docs.

hanzei commented 4 years ago

Skipping QA as this plugin is not in the Marketplace yet.

hanzei commented 4 years ago

Thanks for the contribution @AugustasV :rocket: