mattermost-community / mattermost-plugin-agenda

Mattermost plugin to handle meeting agendas
Apache License 2.0
35 stars 21 forks source link

update dependencies #55

Closed jfrerich closed 4 years ago

jfrerich commented 4 years ago

Summary

In prep for the v0.1.0 release, we should fix these dependabot alerts.

image

Ticket Link

n/a

codecov[bot] commented 4 years ago

Codecov Report

Merging #55 into master will increase coverage by 2.04%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   26.23%   28.27%   +2.04%     
==========================================
  Files           6        6              
  Lines         343      343              
==========================================
+ Hits           90       97       +7     
+ Misses        235      229       -6     
+ Partials       18       17       -1     
Impacted Files Coverage Δ
server/utils.go 95.12% <0.00%> (+17.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0f165d1...5489921. Read the comment docs.

jfrerich commented 4 years ago

@hanzei, package-lock.json changed considerably after running npm audit fix.

After running npm install on master, we see the following: image

After running npm audit fix the low severity packages were also updated. image

It looks like Dependabot only highlights medium and high severity issues, but running npm audit fix fixes the low severity dependencies also.

If we prefer only to fix the two dependabot notifications, I can rerun the following and reduce the total number of dependency updates:

hanzei commented 4 years ago

I'm 1/5 to only fix the ones that Dependabot reports. We don't have a process for the other ones.

If there is an easy way to fix only these two, I would prefer it, but if there is none, I'm fine with using npm audit fix.

hanzei commented 4 years ago

It might be fine to skip QA review here, as release testing is coming up soon after.

jfrerich commented 4 years ago

agree! Merging!