search

mattermost-community / mattermost-plugin-agenda

Mattermost plugin to handle meeting agendas
Apache License 2.0
34 stars 21 forks source link

Fix panic if channel is meeting is not found #59

Closed hanzei closed 4 years ago

hanzei commented 4 years ago

Summary

Fix a panic if the meeting for autocomplete and add a log message.

Ticket Link

https://community-daily.mattermost.com/core/pl/g5c8dwh5ufrtpprtontzeecnuc

codecov[bot] commented 4 years ago

Codecov Report

Merging #59 into master will decrease coverage by 0.16%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
- Coverage   26.04%   25.87%   -0.17%     
==========================================
  Files           6        6              
  Lines         311      313       +2     
==========================================
  Hits           81       81              
- Misses        213      215       +2     
  Partials       17       17
Impacted Files Coverage Δ
server/plugin.go 22.58% <0.00%> (-0.50%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dd0e9dd...9e0462c. Read the comment docs.

DHaussermann commented 4 years ago

@hanzei any thoughts on testing this? Would I need a way to simulate such an error?

hanzei commented 4 years ago

@DHaussermann Not really. I don't know what causes the crash, which is why I added the log statement.

hanzei commented 4 years ago

@DHaussermann Would you be fine skipping QA review?

DHaussermann commented 4 years ago

@hanzei, makes sense to me. As it is there is no functional testing I can do. LGTM!