search

mattermost-community / mattermost-plugin-agenda

Mattermost plugin to handle meeting agendas
Apache License 2.0
32 stars 21 forks source link

Add more manifest metadata #71

Closed hanzei closed 3 years ago

hanzei commented 3 years ago

Summary

Add homepage_url and support_url to the manifest. support_url is not jet used in the webapp, but there is no downside of defining it already.

I've tested the changes locally and can confirm that the link to the homepage_url is correctly shown.

Ticket Link

Part of https://github.com/mattermost/mattermost-plugin-agenda/issues/69

codecov[bot] commented 3 years ago

Codecov Report

Merging #71 into master will increase coverage by 1.58%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   23.80%   25.39%   +1.58%     
==========================================
  Files           7        7              
  Lines         315      315              
==========================================
+ Hits           75       80       +5     
+ Misses        222      217       -5     
  Partials       18       18
Impacted Files Coverage Δ
server/manifest.go 100.00% <ø> (ø)
server/utils.go 87.87% <0.00%> (+15.15%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4aa5369...33d6848. Read the comment docs.

hanzei commented 3 years ago

Let's skip QA review here and review the changes in the release process.