search

mattermost-community / mattermost-plugin-agenda

Mattermost plugin to handle meeting agendas
Apache License 2.0
32 stars 21 forks source link

Agenda item number should get updated if the items of the agenda are deleted #79

Closed maisnamrajusingh closed 2 years ago

maisnamrajusingh commented 2 years ago

Summary

Agenda item number should get updated if the items of the agenda are deleted

Ticket Link

https://github.com/mattermost/mattermost-plugin-agenda/issues/47

codecov[bot] commented 2 years ago

Codecov Report

Merging #79 (9b332a8) into master (2f22484) will decrease coverage by 3.73%. The diff coverage is 5.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage   26.03%   22.29%   -3.74%     
==========================================
  Files           7        7              
  Lines         315      453     +138     
==========================================
+ Hits           82      101      +19     
- Misses        216      334     +118     
- Partials       17       18       +1
Impacted Files Coverage Δ
server/command.go 0.00% <0.00%> (ø)
server/utils.go 72.54% <0.00%> (-21.40%) :arrow_down:
server/meeting.go 62.06% <50.00%> (-0.98%) :arrow_down:
server/main.go 0.00% <0.00%> (ø)
server/manifest.go 100.00% <0.00%> (ø)
server/configuration.go 0.00% <0.00%> (ø)
server/plugin.go 25.74% <0.00%> (+3.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f22484...9b332a8. Read the comment docs.

hanzei commented 2 years ago

@maisnamrajusingh There seem to be a lot of unrelated changes in this PR. Could you please double check that only needed changes got in here?

maisnamraju commented 2 years ago

@maisnamrajusingh There seem to be a lot of unrelated changes in this PR. Could you please double check that only needed changes got in here?

yup, seems there are unrelated changes. Sorry about that, will update later today or tomorrow.