[GH-47] [FIX] Agenda item number should get updated if the items of the agenda are deleted

[sanjaydemansol]

Summary

Fixes #47 Now, Whenever we add new agenda item. Plugin searches for old messages for that hashtag. If some item is missing(deleted), it fixes numbering for all items.

Testing

Ensure that the agenda plugin is installed and enabled. Go to a channel header and edit the agenda settings to update the prefix and Use command /agenda queue to queue at least 3 items as following: /agenda queue item 1 /agenda queue item 2 /agenda queue item 3

Click on the agenda hashtag to open up the agenda list on the RHS. On the RHS, click the post menu for item 1 (or the first item that was queued) and delete the agenda item. Ensure that now there are only 2 items for that agenda hashtag: item 2 and item 3 on the RHS. Add a new agenda item: /agenda queue new item. Click on the hashtag to refresh the RHS.

Outcome: The RHS has 3 agenda items numbered 1), 2) and 3)

Ticket Link

https://github.com/mattermost/mattermost-plugin-agenda/issues/47

---

[codecov[bot]]

Codecov Report

Merging #88 (dd95544) into master (2f22484) will decrease coverage by 4.83%. The diff coverage is 5.83%.

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
- Coverage   26.03%   21.19%   -4.84%     
==========================================
  Files           7        7              
  Lines         315      453     +138     
==========================================
+ Hits           82       96      +14     
- Misses        216      339     +123     
- Partials       17       18       +1     

Impacted Files	Coverage Δ
server/command.go	0.00% <0.00%> (ø)
server/utils.go	62.74% <0.00%> (-31.20%)	:arrow_down:
server/meeting.go	62.06% <50.00%> (-0.98%)	:arrow_down:
server/main.go	0.00% <0.00%> (ø)
server/manifest.go	100.00% <0.00%> (ø)
server/configuration.go	0.00% <0.00%> (ø)
server/plugin.go	25.74% <0.00%> (+3.16%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f22484...dd95544. Read the comment docs.

[mickmister]

I accidentally reviewed the code for requeueing items because that is the majority of the PR. Please remove any code not related to changing the existing meeting items.

[sanjaydemansol]

Blocking until the re-queue changes have been removed

Please follow sequence for reviewing these three PRs #66->#12->#47. There is one commit for each issue.

[jfrerich]

@sanjaydemansol, can you pull the code into 3 separate PRs, one for each issue? #66, #12, and #47.

[jfrerich]

Actually, I see the PRs have been separated per issue. The remaining work for this PR is to remove the code relative to PR #86 and #87

[sanjaydemansol]

Actually, I see the PRs have been separated per issue. The remaining work for this PR is to remove the code relative to PR #86 and #87

Actually #86 is the base for #87 and #87 is base for this PR(#88).

[dipak-demansol]

@hanzei hii, you added the invalid label but i don't understand the label is for Dev or Qa, should i need to test this PR?

[hanzei]

@dipak-demansol No, there is nothing to test here