Closed sanjaydemansol closed 2 years ago
Merging #90 (c5abeee) into master (2f22484) will decrease coverage by
1.46%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #90 +/- ##
==========================================
- Coverage 26.03% 24.56% -1.47%
==========================================
Files 7 7
Lines 315 403 +88
==========================================
+ Hits 82 99 +17
- Misses 216 287 +71
Partials 17 17
Impacted Files | Coverage Δ | |
---|---|---|
server/command.go | 0.00% <0.00%> (ø) |
|
server/meeting.go | 40.00% <0.00%> (-23.05%) |
:arrow_down: |
server/main.go | 0.00% <0.00%> (ø) |
|
server/manifest.go | 100.00% <0.00%> (ø) |
|
server/configuration.go | 0.00% <0.00%> (ø) |
|
server/utils.go | 95.12% <0.00%> (+1.18%) |
:arrow_up: |
server/plugin.go | 25.74% <0.00%> (+3.16%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2f22484...c5abeee. Read the comment docs.
@sanjaydemansol LGTM
@sanjaydemansol i forgot to add the review so i will check it again and will add the review.
@sanjaydemansol @hanzei This PR is Tested From my side but i don't have pull review request for this PR, can someone send me that.
@dipak-demansol This is ready for review
Summary
Fixes #47 Now, Whenever we add new agenda item. Plugin searches for old messages for that hashtag. If some item is missing(deleted), it fixes numbering for all items.
Testing
Ensure that the agenda plugin is installed and enabled. Go to a channel header and edit the agenda settings to update the prefix and Use command /agenda queue to queue at least 3 items as following:
/agenda queue item 1
/agenda queue item 2
/agenda queue item 3
Click on the agenda hashtag to open up the agenda list on the RHS. On the RHS, click the post menu for item 1 (or the first item that was queued) and delete the agenda item. Ensure that now there are only 2 items for that agenda hashtag: item 2 and item 3 on the RHS. Add a new agenda item: /agenda queue new item. Click on the hashtag to refresh the RHS.
Outcome: The RHS has 3 agenda items numbered 1), 2) and 3)
Ticket Link
https://github.com/mattermost/mattermost-plugin-agenda/issues/47