search

mattermost-community / mattermost-plugin-antivirus

Antivirus plugin for scanning files uploaded to Mattermost
Apache License 2.0
35 stars 23 forks source link

Throw a server connect error more clearly #7

Closed aaronrothschild closed 4 years ago

aaronrothschild commented 5 years ago

If MM can't connect to the clamav server, the returned error is not very clear. You'll notice that it's not working because you can't post any attachments at all and the error says "Error while scanning for viruses"

2019-07-26_11-52-33

Lumexralph commented 5 years ago

@hanzei I would love to help with this

hanzei commented 5 years ago

Awesome! Thanks for working on this @Lumexralph :+1:

Lumexralph commented 5 years ago

@aaronrothschild How can I reproduce the issue locally? Also, what kind of error message do you think or suggest should be displayed? @hanzei

hanzei commented 5 years ago

@Lumexralph You can just configure the Host and Port to something invalid in Step 4 of the installation process (https://github.com/mattermost/mattermost-plugin-antivirus#installation)

Lumexralph commented 5 years ago

@aaronrothschild what kind of error message do you think or suggest should be displayed?

aaronrothschild commented 5 years ago

@aaronrothschild what kind of error message do you think or suggest should be displayed?

@Lumexralph Sorry for the missed reply. I'd suggest something like "File Scanning Server unreachable, contact your Mattermost administrator for assistance"

levb commented 4 years ago

@Lumexralph Are you interested in finishing this ticket, or should we put it back up for grabs?

anidok commented 4 years ago

@levb I would like to take up this one.

hanzei commented 4 years ago

Thanks @anidok :+1: