mattermost-community / mattermost-plugin-autolink

Automatically rewrite text matching a regular expression into a markdown link.

Apache License 2.0

131 stars 57 forks source link

[issue-174] Add Jira Autolink Issue With Comment Test Case #185

Closed sibasankarnayak closed 2 years ago

sibasankarnayak commented 2 years ago

added jira test for url with comment and made it project independent

ticket here Fixes #174

mattermod commented 2 years ago

Hello @sibasankarnayak,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

codecov-commenter commented 2 years ago

Codecov Report

Merging #185 (08b75cf) into master (affe9ee) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #185   +/-   ##
=======================================
  Coverage   41.49%   41.49%           
=======================================
  Files           6        6           
  Lines         670      670           
=======================================
  Hits          278      278           
  Misses        375      375           
  Partials       17       17

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update affe9ee...08b75cf. Read the comment docs.

sibasankarnayak commented 2 years ago

@mickmister added the test for regex independent of project.

mattermod commented 2 years ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

hanzei commented 2 years ago

Sorry @mickmister , I should have waited for your review.

sibasankarnayak commented 2 years ago

I have a few questions on this. Since this PR is a proxy for how we will implement this in the Jira plugin, I'd like to resolve concerns here first, even though this is already merged.

@mickmister sure i raised this PR with your suggested changes , wanted suggestion for message on comment like how should it look like.

This is the PR raised against your suggestion https://github.com/mattermost/mattermost-plugin-autolink/pull/189

mickmister commented 2 years ago

Sorry @mickmister, I should have waited for your review.

No worries @hanzei. It took me quite a while to get to this 🙂