mattermost-community / mattermost-plugin-autolink

Automatically rewrite text matching a regular expression into a markdown link.

Apache License 2.0

132 stars 57 forks source link

Properly escape $-usage with span-tags #198

Closed ichistmeinname closed 1 year ago

ichistmeinname commented 2 years ago

Summary

On May 19th GitHub Markdown started to support math-mode using $-signs which breaks the documentation; see usage here. Span-tags are the way to fix a direct usage of $ in text mode.

mattermod commented 2 years ago

Hello @ichistmeinname,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement? Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

ichistmeinname commented 2 years ago

/check-cla

codecov-commenter commented 2 years ago

Codecov Report

Merging #198 (cd5637f) into master (3282131) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #198   +/-   ##
=======================================
  Coverage   40.79%   40.79%           
=======================================
  Files           6        6           
  Lines         679      679           
=======================================
  Hits          277      277           
  Misses        382      382           
  Partials       20       20

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3282131...cd5637f. Read the comment docs.

mattermod commented 2 years ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

hanzei commented 2 years ago

/check-cla