mattermost-community / mattermost-plugin-autolink

Automatically rewrite text matching a regular expression into a markdown link.
Apache License 2.0
131 stars 57 forks source link

[GH-208] Add feedback if the list link is empty #211

Closed Viktor-Yakovchuk closed 1 year ago

Viktor-Yakovchuk commented 1 year ago

Add feedback if the list link is empty Fixes https://github.com/mattermost/mattermost-plugin-autolink/issues/208

Summary

Ticket Link

mattermost-build commented 1 year ago

Hello @Viktor-Yakovchuk,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement? Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

Viktor-Yakovchuk commented 1 year ago

/check-cla

Viktor-Yakovchuk commented 1 year ago

@hanzei could you please take a look?

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.15 :warning:

Comparison is base (5afadc7) 40.09% compared to head (162bc0a) 39.95%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #211 +/- ## ========================================== - Coverage 40.09% 39.95% -0.15% ========================================== Files 6 6 Lines 833 836 +3 ========================================== Hits 334 334 - Misses 479 482 +3 Partials 20 20 ``` | [Impacted Files](https://codecov.io/gh/mattermost/mattermost-plugin-autolink/pull/211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost) | Coverage Δ | | |---|---|---| | [server/autolinkplugin/command.go](https://codecov.io/gh/mattermost/mattermost-plugin-autolink/pull/211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-c2VydmVyL2F1dG9saW5rcGx1Z2luL2NvbW1hbmQuZ28=) | `0.00% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mattermost-build commented 1 year ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

Viktor-Yakovchuk commented 1 year ago

@DHaussermann gentle ping