search

mattermost-community / mattermost-plugin-aws-SNS

Plugin that receives SNS notification from Alerts created by AWS CloudWatch and sent via AWS SNS
Apache License 2.0
21 stars 22 forks source link

Add autocomplete icon #46

Closed hanzei closed 3 years ago

hanzei commented 4 years ago

Since v5.24 slash commands can provide an svg via AutocompleteIconData in model.Command that is then shown in the autocomplete list. This ticket is about adding the icon in assets to the slash command.

Include screenhots from a dark and a bright theme in the PR description, as there might be the need for a separate icon with a white background for autocomplete.

Similar PRs: For GitHub plugin https://github.com/mattermost/mattermost-plugin-github/pull/359 For Jira plugin https://github.com/mattermost/mattermost-plugin-jira/pull/653

Amyth07 commented 3 years ago

@hanzei can I take this, if no one have claimed it yet?

hanzei commented 3 years ago

All yours @Amyth07 :+1: Let me know if you have any questions.

hanzei commented 3 years ago

@Amyth07 Just wanted to check if you are still working on this. Let me know if you have any questions.

ByeongsuPark commented 3 years ago

Hi, Would I be able to take this issue?

hanzei commented 3 years ago

Sure, thanks @ByeongsuPark :+1: