mattermost-community / mattermost-plugin-aws-SNS

Plugin that receives SNS notification from Alerts created by AWS CloudWatch and sent via AWS SNS
Apache License 2.0
21 stars 22 forks source link

RDS Events support #49

Closed limod closed 3 years ago

limod commented 3 years ago

Summary

I added the processing of RDS Events since they work over SNS subscription too and i found no alternative plugin. This is my first experience with go, feedback welcome. Also i think this project has no tests i should adapt?

mattermod commented 3 years ago

Hello @limod,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement? Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

hanzei commented 3 years ago

/check-cla

mickmister commented 3 years ago

Also I think this project has no tests i should adapt?

@limod Feel free to add tests as you see fit. Any code that is entirely webhook driven should be pretty testable.

mattermod commented 3 years ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

jfrerich commented 3 years ago

@DHaussermann, gentle ping for review

limod commented 3 years ago

Is this PR dead?

jasonblais commented 3 years ago

@DHaussermann Kind reminder with a review here - or delegate to another QA if you currently don't have the time?