Closed ioandim closed 12 months ago
Hello @ioandim,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla
and confirm that the CLA check is green.
This is a standard procedure for many open source projects.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.
Thank you very much for the contribution @ioandim :tada:
Could you please take a look at the CI failures? You can find them here here.
@stylianosrigas I'm wondering if you would be open on giving this PR a review as a SME on AWS.
@mickmister I have added a new implementation that includes the errors discussed above. Let me know about your thoughts and ideas on the implemented changes.
@mickmister We can determine weather the message refers to a Cloudformation event notification by checking if the StackId field is included. Then, we can safely check weather the format of the Cloudformation event message is valid. I have edited the messageToJSON function in order to include these checks.
@stylianosrigas This should be a short review when you have a chance. No rush on this
@ioandim Can you please provide basic test steps to test this PR's functionality? We'll be able to merge this sooner if we have steps readily available.
Thanks for this contribution @ioandim!
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
/cc @jasonblais @jfrerich @emilyacook
@ioandim Are you able to provide test steps for this PR?
@mickmister I apologize for not coming back to you sooner. Unfortunately, I was not able to do so during the past months. The functionality for this PR can be tested by following these steps:
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
/update-branch
We don't have permissions to update this PR, please contact the submitter to apply the update.
@DHaussermann I have updated the branch with all of the current changes.
Any updates?
cc @DHaussermann
@ioandim Can you please merge master
into this PR?
@hanzei I've merged the changes from master
to this branch in a separate PR https://github.com/mattermost/mattermost-plugin-aws-SNS/pull/79.
This pull request adds support for Cloudformation events. The form of a cloudformation event message is the following:
StackId=
Timestamp=
EventId=
LogicalResourceId=
Namespace=
PhysicalResourceId=
PrincipalId=
ResourceProperties=
ResourceStatus=
ResourceStatusReason=
ResourceType=
The message is firstly converted to JSON format. Then it is processed in a similar way to the rest of the supported events.