Closed limod closed 11 months ago
Hello @limod,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Attention: 73 lines
in your changes are missing coverage. Please review.
Comparison is base (
363b452
) 0.00% compared to head (d22dc40
) 17.03%. Report is 2 commits behind head on master.:exclamation: Current head d22dc40 differs from pull request most recent head d57bf24. Consider uploading reports for the commit d57bf24 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Accidentally removed @stylianosrigas, i am not able to readd him. @mickmister
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
When will the review continue?
@mkdbns @DHaussermann @jasonblais Thoughts on handling QA review on community contributions like this?
@mkdbns would this be an example contribution for your team to QA review & merge once your team has the proper GitHub access?
@limod @mickmister From our QA
Tested and Passed The comment above is necessary for this PR to work and I have tested everything after making that change because without that the token will always be incorrect.
1) Tested the plugin by updating the system console values to include multiple channels and notifications are coming successfully.
2) Cases handled:- i) Invalid channelID in both the system console and in the URL. ii) URL without channelid also works fine.
Thanks for the contribution @limod!
Hi!
i added the feature to specify multiple channels. We have multiple environments and want to seperate your monitoring into different mattermost channels.
You can configure the field
Channels to send notifications
to include multiple channels separated by;
e.g.teamname,channelname;teamname-2,channelname-2
You can configure the target channel in the webhook URL, e.g.
https://your-mattermost-url/plugins/com.mattermost.aws-sns?token=your-mattermost-token?channel=teamname,channelname
If you specify no
channel
query parameter, the first channel will be used. Therefore the change should be compatible with older version.Added some tests: go test ./... -cover
Added the flag
CGO_ENABLED=0
in the Makefile because i hat problems running the plugin in a dev mattermost setup (Image: mattermost/mattermost-team-edition:7.4.0): Plugin could not start becasue of errorGLIBC_2.34 not found
, with local development in the current mattermost-server project, everything worked without the flag. Any ideas why i hit this error?