mattermost-community / mattermost-plugin-bitbucket

Mattermost plugin for Bitbucket
Apache License 2.0
6 stars 16 forks source link

Feature/25176 bitbucket readme #125

Open kat-kan opened 8 months ago

kat-kan commented 8 months ago

Summary

This PR organizes README.md, admin-guide.md and project assets in a way described here https://github.com/mattermost/mattermost/issues/25176 I have

Ticket Link

Fixes https://github.com/mattermost/mattermost/issues/25176 https://mattermost.atlassian.net/browse/MM-55077

mattermost-build commented 8 months ago

Hello @kat-kan,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement? Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

kat-kan commented 8 months ago

/check-cla

kat-kan commented 8 months ago

image image

cwarnermm commented 8 months ago

@mickmister - Looking forward to your technical review of this PR -- particularly the image updates.

kat-kan commented 8 months ago

I am also looking forward to the review :)

cwarnermm commented 8 months ago

@kat-kan - You've done a very good job with this PR. Thank you for being so flexible and understanding about the feedback you received during @hanzei's technical review.

@hanzei - Thank you for a most excellent review! :)

cwarnermm commented 8 months ago

@hanzei - I believe the only check remaining is to ensure that the image assets are in the correct location.

kat-kan commented 8 months ago

@cwarnermm I believe they are but builds are failing after moving images because they expect specific location. I am waiting for confirmation that I should revert changes.

kat-kan commented 8 months ago

I reverted the changes related to images, every suggestion was introduced

kat-kan commented 8 months ago

@cwarnermm as we are still waiting for @hanzei to accept the changes, can you please consider adding "hacktoberfest-accepted" label? The review period in Hacktoberfest ends tomorrow and PR has to be either merged or have the label to be even considered.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (84a4030) 15.03% compared to head (29bf6d4) 15.03%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #125 +/- ## ======================================= Coverage 15.03% 15.03% ======================================= Files 13 13 Lines 2301 2301 ======================================= Hits 346 346 Misses 1936 1936 Partials 19 19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hanzei commented 8 months ago

@mickmister The broken CI is unrelated to the PR. What are the next steps to getting it fixed?

mickmister commented 8 months ago

@hanzei I created https://github.com/mattermost/mattermost-plugin-bitbucket/pull/127 to fix the issue

mickmister commented 8 months ago

/update-branch

mickmister commented 8 months ago

@mickmister - Looking forward to your technical review of this PR -- particularly the image updates.

@cwarnermm I'm not sure there are any image updates in the PR?

mattermost-build commented 7 months ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!