search

mattermost-community / mattermost-plugin-bitbucket

Mattermost plugin for Bitbucket
Apache License 2.0
6 stars 16 forks source link

[Bitbucket Server] Implements the GetMe method #128

Open panoramix360 opened 8 months ago

panoramix360 commented 8 months ago

Summary

This is the first PR to begin the implementation of the Bitbucket Server in the Plugin.

It creates the client_server.go to integrate the Bitbucket Server methods to the Plugin, I implemented the first one GetMe this one does two requests to complete:

This flow is needed because the Bitbucket Server API doesn't have the same methods of the Bitbucket Cloud like /user that already accounts for the logged user.

Ticket Link

Github Issue

mattermost-build commented 8 months ago

Hello @panoramix360,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (bitbucket-server@3be0785). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## bitbucket-server #128 +/- ## =================================================== Coverage ? 15.58% =================================================== Files ? 15 Lines ? 2439 Branches ? 0 =================================================== Hits ? 380 Misses ? 2035 Partials ? 24 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mattermost-build commented 7 months ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

panoramix360 commented 7 months ago

hey @mickmister

I added a Factory Pattern as we discussed, I think this approach is cleaner, can you review it again?

Meanwhile, I'll take a look and solve the other comments.

Can you take a look at some comments that I made as well?

Thanks!

mickmister commented 5 months ago

Hi @panoramix360, this is looking good 👍

Are you able to resolve the lint issues CI is reporting? Thank you!

panoramix360 commented 5 months ago

hey @mickmister, done!

I needed to change the name of the package, and it made more sense to call it bitbucketclient since it will have BitbucketServer and BitbucketCloud implementations.